Repository navigation
fix(egress): answer browser dials when audit is required - #70
Merged
Merged
Conversation
Add a regression test asserting that browser dials, which carry no audit correlation, are still authorized, consumed and validated when the host requires audit. Without this, every browser navigation was refused with "required audit needs bound permission". Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The three browser dial members no longer call require_unbound_permission, so they answer even when audit is required. A dial carries no payload or host audit correlation and only applies destination rules of a policy the authenticated host registered, so refusing it broke every page of a host using this module as its secret authority. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper review
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenHuman loads TinySecurity as its secret authority, and that configuration makes audit required (
module_config_for_secret_authoritysetsaudit.required = true). Under required audit,require_unbound_permissionrefuses every permission member that carries no audit correlation, andAuthorizeBrowserDial,ConsumeBrowserDialandValidateBrowserDialcall it. They have no audited variant and no correlation to carry, so every browser dial is refused withrequired audit needs bound permission. TinyComputer's egress proxy then fails the CONNECT, and Chrome reportsnet::ERR_TUNNEL_CONNECTION_FAILEDon every page.Reproduced on a teeny-spine built from OpenHuman's current pin (tinysecurity 0.21.0): a browser task opening https://example.com/ fails with ERR_TUNNEL_CONNECTION_FAILED, and the core's debug log shows
[security] module call failed: ... required audit needs bound permissionat the dial.Fix
The three browser dial members no longer call
require_unbound_permission. A dial carries no payload, the proxy opens one per connection with no agent turn behind it to bind a durable event to, and the member only applies the destination rules (address floor, DNS pinning, one-use grant, lease) of a policy the authenticated host registered. Every other permission member keeps the required-audit refusal.Test
browser_dials_are_authorized_when_audit_is_requiredruns the browser dial contract (authorize, consume once, validate, refuse a replay) against a service whose audit is required. It failed before the fix withrequired audit needs bound permissionand passes after.cargo test -p tinysecurity-module: 208 passed.